Skip to content

Show epic view

Clement Ho requested to merge 3550-show-epic into master

What does this MR do?

Creates the show_epic view, similar to the show issues view, where we show the title and description of an epic

Are there points in the code the reviewer needs to double check?

This MR contains a few things that are already merged into CE that should be merged into EE soon (CE => EE)

Backend

The epics are very similar to issuables and therefore we use this concern and related classes for them. It needed some refactoring in the concern itself, the controllers actions that are needed by both issues and epics were moved to IssuableActions and also IssuableBaseService had to be changed a bit (I also extracted system note related code to the separated class as it was spread non-logically across the service).

Update backend part includes: changing title, description, start_date, end_date and creating a system note when title or description has changed.

Mentioning epics on the other objects is not included in the scope of this MR.

WIP

Backend

  • preview_markdown refactor
  • finish epics helper methods
  • add missing specs
  • add feature tests
  • reference extractor - extract references based on epic group (test in epic description for now)
    • cross references issues extraction
    • cross references labels extraction
    • cross references milestones extraction
    • cross references merge requests extraction
    • cross references snippets extraction
    • users extractions
  • check ee-only files locations
  • backport to CE

Why was this MR needed?

Deliverable

Screenshots (if relevant)

Screen_Shot_2017-11-01_at_4.05.50_PM

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
    • Has been reviewed by Backend
    • Has been reviewed by Database

What are the relevant issue numbers?

Closes #3550 (closed), https://gitlab.com/gitlab-org/gitlab-ee/issues/3693

Frontend TODOS

  • Fix weird _ in front of username
  • Add spec for epic header
  • Add spec for epic show app
  • create user_avatar_username_link component and spec
  • Integrate with backend epic data
Edited by Sarrah Vesselov

Merge request reports