Add AccessibilityReportsService class
Part of #211389 (closed)
This feature will be behind a feature flag called accessibility_report_view
.
What does this MR do?
This MR adds a new CompareAccessibilityReportsService
which will be used in a follow up MR to generate an accessibility report diff on a MR widget.
Standard approach to leverage our generic service comparison to create a diff, similar to other reports such as CompareTestReportsService or CompareDastReportsService.
Why are we doing this?
Step #10
to introduce Accessibility
Report comparison with our Merge Request Widget.
The entire feature has been developed on an MVC branch, this MR aims to break it down in smaller chunk.
Screenshots
You can see how the feature will look like with the screenshot provided below:
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides - [-] Separation of EE specific content
Availability and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
- [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Dependencies
Merge request reports
Activity
changed milestone to %13.0
added Deliverable GitLab Core VerifyP1 backend devopsverify direction feature flag grouppipeline security typefeature workflowin review + 1 deleted label
1 Message 📖 CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 31144 "Add AccessibilityReportsService class"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 31144 "Add AccessibilityReportsService class"
If this merge request doesn’t need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Avielle Wolfe ( @avielle
)Charlie Ablett ( @cablett
)Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Douglas Barbosa Alexandre
👋 @avielle could you review this MR please?(It depends on 2 other MRs: !30224 (merged) & !30377 (merged))
Edited by Max Orefice
assigned to @avielle
- Resolved by Douglas Barbosa Alexandre
mentioned in merge request !30377 (merged)
added 258 commits
-
b5b18832...7725c5e7 - 257 commits from branch
master
- 3abff140 - Add AccessibilityReportsService class
-
b5b18832...7725c5e7 - 257 commits from branch
added 151 commits
-
3abff140...ac9d5394 - 150 commits from branch
master
- ac74ec5a - Add AccessibilityReportsService class
-
3abff140...ac9d5394 - 150 commits from branch
mentioned in merge request !31369 (merged)
- Resolved by Douglas Barbosa Alexandre
- Resolved by Douglas Barbosa Alexandre
- Resolved by Douglas Barbosa Alexandre
added 211 commits
-
ac74ec5a...56f2d758 - 209 commits from branch
master
- c0c36a8b - Add AccessibilityReportsService class
- 04957516 - Apply code review feedback
-
ac74ec5a...56f2d758 - 209 commits from branch
👋 @dbalexandre could you review this MR please?assigned to @dbalexandre and unassigned @morefice
mentioned in issue #211389 (closed)
enabled an automatic merge when the pipeline for d8a28fd1 succeeds
Thanks, @morefice! LGTM
👍 mentioned in commit 6db62b76
added workflowstaging label and removed workflowin review label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
This merge request has been deployed to the pre.gitlab.com environment, and will be included in the upcoming self-managed GitLab 13.0.0 release.
🤖 This comment is generated automatically using the Release Tools project.added published label
added Category:Code Testing and Coverage testingaccessibility labels