Skip to content
Snippets Groups Projects

Add AccessibilityReportsService class

Merged Max Orefice requested to merge mo-add-accessibility-report-service into master
All threads resolved!

Part of #211389 (closed)

This feature will be behind a feature flag called accessibility_report_view.

What does this MR do?

This MR adds a new CompareAccessibilityReportsService which will be used in a follow up MR to generate an accessibility report diff on a MR widget.

Standard approach to leverage our generic service comparison to create a diff, similar to other reports such as CompareTestReportsService or CompareDastReportsService.

Why are we doing this?

Step #10 to introduce Accessibility Report comparison with our Merge Request Widget.

The entire feature has been developed on an MVC branch, this MR aims to break it down in smaller chunk.

Screenshots

You can see how the feature will look like with the screenshot provided below:

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Dependencies

Edited by Jackie Porter

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Max Orefice mentioned in merge request !30377 (merged)

    mentioned in merge request !30377 (merged)

  • Max Orefice added 258 commits

    added 258 commits

    Compare with previous version

  • Max Orefice added 151 commits

    added 151 commits

    Compare with previous version

  • Max Orefice mentioned in merge request !31369 (merged)

    mentioned in merge request !31369 (merged)

  • Avielle Wolfe approved this merge request

    approved this merge request

  • Avielle Wolfe
  • Avielle Wolfe
  • Avielle Wolfe assigned to @morefice and unassigned @avielle

    assigned to @morefice and unassigned @avielle

  • Max Orefice added 211 commits

    added 211 commits

    Compare with previous version

  • Author Developer

    👋 @dbalexandre could you review this MR please?

  • Max Orefice assigned to @dbalexandre and unassigned @morefice

    assigned to @dbalexandre and unassigned @morefice

  • mentioned in issue #211389 (closed)

  • resolved all threads

  • Douglas Barbosa Alexandre approved this merge request

    approved this merge request

  • Douglas Barbosa Alexandre enabled an automatic merge when the pipeline for d8a28fd1 succeeds

    enabled an automatic merge when the pipeline for d8a28fd1 succeeds

  • Thanks, @morefice! LGTM 👍

  • mentioned in commit 6db62b76

  • added workflowstaging label and removed workflowin review label

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • This merge request has been deployed to the pre.gitlab.com environment, and will be included in the upcoming self-managed GitLab 13.0.0 release.


    🤖 This comment is generated automatically using the Release Tools project.

  • Jackie Porter changed the description

    changed the description

  • Please register or sign in to reply
    Loading