Skip to content
Snippets Groups Projects

Show error message when pipelines disabled and Pipeline must succeed

1 unresolved thread

This is the first step towards fixing the Epic #12686 (closed) to show accurate messages when MR button is disabled. This specific issue should not focus on the problem as a whole, but a very specific instance where the settings are simply invalid and we give no help to users.

  • Pipelines are disabled
  • MR pipeline must succeed is turned on
  • No external CI is setup

This correspond to option C in the EPIC:

C. Pipelines are disabled and there is no pipeline information available for the commit (pipelines were not enabled or there was no ci configuration when the commit was created):

  • Settings -> General -> Merge Requests -> Merge checks -> "Pipelines must succeed" is enabled
  • Settings -> General -> Visibility, project features, permissions -> "Pipelines" is disabled
  • Pipeline information is generally not shown anymore except in merge requests where it is required to succeed.
  • Pipeline section of merge request widget states: No pipeline was run for this commit.
  • The merge section of the merge request widget states: Pipelines must succeed for merge requests to be eligible to merge. Please enable pipelines for this project to continue. For more information, see the documentation.

Screenshots

Before Screen_Shot_2020-05-06_at_1.57.22_PM

After Screen_Shot_2020-05-06_at_1.58.36_PM

Edited by Frédéric Caplette

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Frédéric Caplette changed title from WIP: Resolve "Show accurate error message when: pipelines disabled, MR must succeed option is on and external pipelines are disabled" to WIP: Show accurate error message when pipelines disabled and Pipeline must succeed

    changed title from WIP: Resolve "Show accurate error message when: pipelines disabled, MR must succeed option is on and external pipelines are disabled" to WIP: Show accurate error message when pipelines disabled and Pipeline must succeed

  • Frédéric Caplette changed the description

    changed the description

  • Frédéric Caplette mentioned in merge request !30649 (closed)

    mentioned in merge request !30649 (closed)

  • added 1 commit

    • d39ec5a7 - Handle conflict no CI and pipelines must succeed

    Compare with previous version

  • added 1 commit

    • c57744ca - Handle conflict no CI and pipelines must succeed

    Compare with previous version

  • added 1 commit

    • 1d96b8fa - Handle conflict no CI and pipelines must succeed

    Compare with previous version

  • Frédéric Caplette changed the description

    changed the description

  • Frédéric Caplette unmarked as a Work In Progress

    unmarked as a Work In Progress

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • @f_caplette I think we should also generate a changelog entry for this MR.

  • added 1 commit

    • 7d48c88c - Change test to use component in find

    Compare with previous version

  • Frédéric Caplette changed title from Show accurate error message when pipelines disabled and Pipeline must succeed to Show error message when pipelines disabled and Pipeline must succeed

    changed title from Show accurate error message when pipelines disabled and Pipeline must succeed to Show error message when pipelines disabled and Pipeline must succeed

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Payton Burdette approved this merge request

    approved this merge request

  • Payton Burdette resolved all threads

    resolved all threads

  • Hello @afontaine! Could you give this MR a maintainer review? Thank you! :bow:

  • Andrew Fontaine
  • Andrew Fontaine resolved all threads

    resolved all threads

  • Andrew Fontaine approved this merge request

    approved this merge request

  • Andrew Fontaine mentioned in commit aa272230

    mentioned in commit aa272230

  • Frédéric Caplette resolved all threads

    resolved all threads

  • added workflowstaging label and removed workflowin dev label

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • mentioned in issue #35562 (closed)

  • This merge request has been deployed to the pre.gitlab.com environment, and will be included in the upcoming self-managed GitLab 13.0.0 release.


    :robot: This comment is generated automatically using the Release Tools project.

  • mentioned in issue #216031 (closed)

  • mentioned in issue #216048 (closed)

  • Miranda Fluharty mentioned in merge request !14732 (closed)

    mentioned in merge request !14732 (closed)

  • Please register or sign in to reply
    Loading