Show error message when pipelines disabled and Pipeline must succeed
This is the first step towards fixing the Epic #12686 (closed) to show accurate messages when MR button is disabled. This specific issue should not focus on the problem as a whole, but a very specific instance where the settings are simply invalid and we give no help to users.
- Pipelines are disabled
- MR pipeline must succeed is turned on
- No external CI is setup
This correspond to option C in the EPIC:
C. Pipelines are disabled and there is no pipeline information available for the commit (pipelines were not enabled or there was no ci configuration when the commit was created):
- Settings -> General -> Merge Requests -> Merge checks -> "Pipelines must succeed" is enabled
- Settings -> General -> Visibility, project features, permissions -> "Pipelines" is disabled
- Pipeline information is generally not shown anymore except in merge requests where it is required to succeed.
- Pipeline section of merge request widget states:
No pipeline was run for this commit.
- The merge section of the merge request widget states:
Pipelines must succeed for merge requests to be eligible to merge. Please enable pipelines for this project to continue. For more information, see the documentation.
Screenshots
Merge request reports
Activity
changed milestone to %13.0
added 1 commit
- 1681fb70 - Handle conflict no CI and pipelines must succeed
4 Warnings This merge request changed files with disabled eslint rules. Please consider fixing them. You have edited karma spec files. Please consider migrating them to jest. Please add a throughput label to this merge request. This MR has a Changelog file outside ee/
, but code changes inee/
. Consider moving the Changelog file intoee/
.Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/vue_merge_request_widget/components/mr_widget_pipeline.vue
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/vue_merge_request_widget/components/mr_widget_pipeline.vue'
Edited karma files
You have edited the following karma spec files. Please consider migrating them to jest:
spec/javascripts/vue_mr_widget/components/mr_widget_pipeline_spec.js
spec/javascripts/vue_mr_widget/components/states/mr_widget_ready_to_merge_spec.js
In order to align with our Iteration value, migration can also be done as a follow-up.
For more information: Jestodus epic
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer frontend Zack Cuddy ( @zcuddy
)Andrew Fontaine ( @afontaine
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Frédéric Caplette
- Resolved by Frédéric Caplette
assigned to @f_caplette
mentioned in merge request !30649 (closed)
added 1 commit
- d39ec5a7 - Handle conflict no CI and pipelines must succeed
added 1 commit
- c57744ca - Handle conflict no CI and pipelines must succeed
added 1 commit
- 1d96b8fa - Handle conflict no CI and pipelines must succeed
- Resolved by Payton Burdette
Hey @pburdette could you give this MR a review? You are already pretty familiar with it (and now the pipeline passes!). Thanks!
assigned to @pburdette
- Resolved by Frédéric Caplette
unassigned @pburdette
assigned to @pburdette
- Resolved by Frédéric Caplette
@f_caplette I think we should also generate a changelog entry for this MR.
unassigned @pburdette
assigned to @pburdette
unassigned @pburdette
Hello @afontaine! Could you give this MR a maintainer review? Thank you!
assigned to @afontaine
- Resolved by Frédéric Caplette
Hey @f_caplette I think this looks good to me! Thanks
@afontaine Please don't merge while
master
is broken, per https://about.gitlab.com/handbook/engineering/workflow/#maintaining-throughput-during-broken-master.Ah my apologies @rymai! I completely forgot
mentioned in commit aa272230
mentioned in issue gitlab-com/www-gitlab-com#7605 (closed)
added workflowstaging label and removed workflowin dev label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in issue #35562 (closed)
This merge request has been deployed to the pre.gitlab.com environment, and will be included in the upcoming self-managed GitLab 13.0.0 release.
This comment is generated automatically using the Release Tools project.added published label
mentioned in issue #216031 (closed)
mentioned in issue #216048 (closed)
mentioned in merge request !14732 (closed)