Skip to content

Remove unneeded has_attribute guard for MR external diff storage

Nick Thomas requested to merge 216216-simplify-external-diff-storage-attrs into master

What does this MR do?

These guards were necessary in 11.8 because we might run new code against old schema. Since 12.0 they have been unnecessary, and now we're in %13.0, they're actively impeding understanding. We should be able to remove them now.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Part of #216216 (closed)

Edited by Nick Thomas

Merge request reports

Loading