Skip to content

Allows new purchase flow to handle upgrades

Alper Akgun requested to merge 211423-allow-upgrades-for-new-purchase-flow into master

What does this MR do?

Allows new purchase flow to handle upgrades !29232 (comment 328773832)

  • We should allow an existing user to initiate and return back to a proper screen with a custom redirect
  • Also @kcomoli comment there !29232 (comment 328979637) we should make sure we get the correct flow at the end of the payment.
  • We should also make sure personal & group namespaces are handled properly if needed

Suggestion

suggestion (non-blocking): we can simplify this code, if we pass groups default value as []. (this will work if groups is undefined or not provided, but will not work if groups is null) This will allow us to eliminate extra early return See !29232 (comment 337222479)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #211423 (closed)

Edited by Alper Akgun

Merge request reports