Skip to content

Pass user rather than user ID to SpamActionService

charlie ablett requested to merge 212213-cablett-action-service-user-arg into master

What does this MR do?

Now that the separation of concerns with regard to spam checking is clear, we can introduce early return for some cases. This is in preparation for #212213 (closed). There's no reason why we can't pass objects to the SpamActionService (unlike SpamVerdictService), and this allows us to ask the user object directly (rather than re-fetching and making the query take longer).

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #212213 (closed)

Edited by charlie ablett

Merge request reports