Merge Geo Replication Views
What does this MR do?
Closes #213219 (closed)
Currently, everytime we add a new replicable type, we have to add yet another option to the Geo Admin Sidebar. This is quickly becoming a problem as Geo Self-Service is getting closer and closer to being a reality.
This MR updates the navigational design of the Geo Subpages into one centralized view under Geo Replication. This will allows us to continue to grow the supported replicables in Geo without an immediate threat to our UI.
This also provides a centralized place for our users to find replication information on their secondary nodes.
Important Notes
-
Based on our direction, the Projects and Uploads approach via HAML with controller based data is legacy. I will open up 2 issues (#216317 (closed), #216319 (closed)) to track the large effort moving them to Self-Service, Exposing a GraphQL Endpoint, and moving all their code into Vue. This will then allow us to remove the
_replication_nav.html.hamland_filter_nav.html.hamlfile in this MR. -
The routing for subpages has changed from
admin/geo/*=>admin/geo/replication/*. I added redirects to not send a user to a 404 if they come in from a bookmark/history.
Screenshots
| Geo Replication | |
|---|---|
| before |  |
| after |  |
Gif
Functionality:
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team