Skip to content

Modify mutation to add Project to Instance Security Dashboard

What does this MR do?

Related to #214583 (closed)

This MR introduces small change to mutation introduced in my last MR !30092 (merged). After some investigation I do not believe we should support mutation that accept multiple project_ids, but have mutation that accept Project ID only and allow users to use multiple mutations to add multiple Projects to the Instance Security Dashboard.

Before:

mutation {
  AddProjectsToSecurityDashboard(input: { project_ids: ["gid://gitlab/Project/60", "gid://gitlab/Project/54"] }) {
    errors
  }
}

After:

mutation {
  project_1: AddProjectToSecurityDashboard(input: { id: "gid://gitlab/Project/60" }) {
    project {
      id
    }
    errors
  }
  
  project_2: AddProjectToSecurityDashboard(input: { id: "gid://gitlab/Project/54" }) {
    project {
      id
    }
    errors
  }
}

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Alan (Maciej) Paruszewski

Merge request reports