Resolve member expiration duplicate API call
What does this MR do?
This MR solves the duplicate API call being made when changing or removing a group / project member's expiration date.
How?
By removing the change events being fired in app/assets/javascripts/member_expiration_date.js
.
Why?
Pikaday
already fires a change event for both cases.
Additional thoughts
The .off('change')
call in member_expiration_date.js
doesn't remove Pikaday
's EHs. Even when delayed it doesn't have the desired effect.
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #204809 (closed)
Edited by Jiaan Louw