Skip to content

Remove Visibility from terraform widget

Emily Ring requested to merge emilyring-terraform-mr-fix into master

What does this MR do?

The terraform widget was setup following other polling examples in the codebase, using Visibility.

Visibility seems to make unintended polling requests.

For example, when I click away from a screen (maybe to another tab on my browser) and click back a new poll request will generate. This will appear as a reload to the customer, even though they did not reload the page.

I did a bit more research and discovered Visibility is not required for polling, so I've removed it from the file.

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports