Skip to content

Disable diff file edit button if source branch is deleted

Phil Hughes requested to merge ph/213263/editButtonOnMergeRequestDiffs into master

What does this MR do?

Changes the behaviour of the edit button to follows:

  • If merged, the edit button points to the file in the target branch
  • If not merged and the source branch is deleted, the edit button gets disabled.

Screenshots

Screenshot_2020-04-29_at_11.42.39

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #213263 (closed)

Merge request reports