Skip to content

Fix checkmark position on dropdowns

Simon Knox requested to merge psi-dropdown-item-check into master

What does this MR do?

Possible solution for #215960 (closed)

removing :not(.gl-dropdown), and de-nesting .dropdown-item from .dropdown-menu. Means gl-new-dropdown's styles are more specific than the default gitlab dropdown-item.

Could potentially change specificity in case of existing overrides. For any .dropdown-items that have another class applied that class could now take precedence over the dropdown-menu styles. However every instance I can find is adding utility classes, which are already intentionally more specific than nested .dropdown-item (mostly utils using !important)

AND most regular dropdown the styles are duplicated in the .dropdown-menu li button which includes the exact same mixin

Screenshots

Before After
Screen_Shot_2020-04-29_at_2.17.26_pm Screen_Shot_2020-04-29_at_2.12.36_pm

And gl-new-dropdown still looks ok! (height issue is unrelated)

Screen_Shot_2020-04-29_at_2.12.22_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Simon Knox

Merge request reports