Skip to content

Split BaseService to ContainerBaseService

Mark Chao requested to merge refactor-base-service into master

What does this MR do?

Currently BaseService accepts a project. However we need to expand it to accept either a group or a project, since wiki can now belong to group. This MR introduces a ContainerBaseService, where the container can either be a project or a group.

The original BaseService will be more barebone, not knowing projects at all. This opens up future improvement opportunities for some service classes since they aren't really related to project at all.

One main discussion is on the naming choice of ContainerBaseService. If you want to discuss about this, join the thread here: !30681 (comment 333725944)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Mark Chao

Merge request reports