Add check for new email addition in audit test
What does this MR do?
Closes #207741 (closed).
We're failing in the test qa/qa/specs/features/ee/browser_ui/1_manage/instance/instance_audit_logs_spec.rb because during the addition of a new email step we are not verifying that the email was added. Thus adding the email can fail, and when the test looks at the audit log for the new email added it will fail. So I've just added an expectation that ensures we have added the email and wrapped it in a retrier so that we can retry the addition of the email if the page fails to load.
A risk is that if the email page won't load properly then we could spend more time looking for a button that won't show up until the page is fixed.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team