Add initial Iteration GraphQL endpoint (!30670) · Merge requests · GitLab.org / GitLab

Mario de la Ossa requested to merge 214713-sprint_graphql into master Apr 28, 2020

What does this MR do?

Initial implementation of the Iterations (&2422) GraphQL endpoint.

Added an IterationType for GraphQL, and added it as a response to Group, and Issue.

Mutations:

IssueSetIteration: assigns Iterations to Issues
CreateIteration: creates Group-level iterations. Accepts title, description, start_date, and due_date.

Database: I had to rename status to status_id because I needed status to be a symbol, just like Issue or MergeRequest do it

P.S.: Note that while we've decided to rename Sprint to Iteration, this MR doesn't yet rename the model itself.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
Tested in all supported browsers
Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

Label as security and @ mention @gitlab-com/gl-security/appsec
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
Security reports checked/validated by a reviewer from the AppSec team

Database

Migrations

UP:

== 20200429001827 SprintRenameStateToStateEnum: migrating =======================
-- column_exists?(:sprints, :id)
   -> 0.0024s
-- transaction_open?()
   -> 0.0000s
-- columns(:sprints)
   -> 0.0017s
-- add_column(:sprints, :state_enum, :integer, {:limit=>2, :precision=>nil, :scale=>nil})
   -> 0.0009s
-- transaction_open?()
   -> 0.0000s
-- exec_query("SELECT COUNT(*) AS count FROM \"sprints\"")
   -> 0.0012s
-- exec_query("SELECT \"sprints\".\"id\" FROM \"sprints\" ORDER BY \"sprints\".\"id\" ASC LIMIT 1")
   -> 0.0004s
-- exec_query("SELECT \"sprints\".\"id\" FROM \"sprints\" WHERE \"sprints\".\"id\" >= 1 ORDER BY \"sprints\".\"id\" ASC LIMIT 1 OFFSET 1")
   -> 0.0003s
-- execute("UPDATE \"sprints\" SET \"state_enum\" = \"sprints\".\"state\" WHERE \"sprints\".\"id\" >= 1 AND \"sprints\".\"id\" < 2")
   -> 0.0005s
-- exec_query("SELECT \"sprints\".\"id\" FROM \"sprints\" WHERE \"sprints\".\"id\" >= 2 ORDER BY \"sprints\".\"id\" ASC LIMIT 1 OFFSET 1")
   -> 0.0003s
-- execute("UPDATE \"sprints\" SET \"state_enum\" = \"sprints\".\"state\" WHERE \"sprints\".\"id\" >= 2 AND \"sprints\".\"id\" < 3")
   -> 0.0004s
-- exec_query("SELECT \"sprints\".\"id\" FROM \"sprints\" WHERE \"sprints\".\"id\" >= 3 ORDER BY \"sprints\".\"id\" ASC LIMIT 1 OFFSET 1")
   -> 0.0003s
-- execute("UPDATE \"sprints\" SET \"state_enum\" = \"sprints\".\"state\" WHERE \"sprints\".\"id\" >= 3")
   -> 0.0004s
-- indexes(:sprints)
   -> 0.0037s
-- foreign_keys(:sprints)
   -> 0.0024s
-- quote_table_name(:sprints)
   -> 0.0000s
-- quote_column_name(:state)
   -> 0.0000s
-- quote_column_name(:state_enum)
   -> 0.0000s
-- execute("CREATE OR REPLACE FUNCTION trigger_f14363ffbcd3()\nRETURNS trigger AS\n$BODY$\nBEGIN\n  NEW.\"state_enum\" := NEW.\"state\";\n  RETURN NEW;\nEND;\n$BODY$\nLANGUAGE 'plpgsql'\nVOLATILE\n")
   -> 0.0088s
-- execute("DROP TRIGGER IF EXISTS trigger_f14363ffbcd3\nON \"sprints\"\n")
   -> 0.0002s
-- execute("CREATE TRIGGER trigger_f14363ffbcd3\nBEFORE INSERT OR UPDATE\nON \"sprints\"\nFOR EACH ROW\nEXECUTE PROCEDURE trigger_f14363ffbcd3()\n")
   -> 0.0006s
== 20200429001827 SprintRenameStateToStateEnum: migrated (0.0334s) ==============

== 20200429002150 CleanupSprintsStateRename: migrating ========================
-- execute("DROP TRIGGER IF EXISTS trigger_7873bd747066 ON sprints")
   -> 0.0012s
-- execute("DROP FUNCTION IF EXISTS trigger_7873bd747066()")
   -> 0.0004s
-- remove_column(:sprints, :state)
   -> 0.0010s
== 20200429002150 CleanupSprintsStateRename: migrated (0.0031s) ===============

== 20200512164334 SprintMakeStateEnumNotNullAndDefault: migrating ==========
-- change_column_default(:sprints, :state_enum, {:from=>0, :to=>1})
   -> 0.0160s
-- change_column_null(:sprints, :state_enum, false, 1)
   -> 0.0082s
== 20200512164334 SprintMakeStateEnumNotNullAndDefault: migrated (0.0243s) =

DOWN:

== 20200512164334 SprintMakeStateEnumNotNullAndDefault: reverting ==========
-- change_column_null(:sprints, :state_enum, true)
   -> 0.0011s
-- change_column_default(:sprints, :state_enum, {:from=>1, :to=>nil})
   -> 0.0046s
== 20200512164334 SprintMakeStateEnumNotNullAndDefault: reverted (0.0058s) =

== 20200429002150 CleanupSprintsStateRename: reverting ========================
-- column_exists?(:sprints, :id)
   -> 0.0024s
-- transaction_open?()
   -> 0.0000s
-- columns(:sprints)
   -> 0.0018s
-- add_column(:sprints, :state, :integer, {:limit=>2, :precision=>nil, :scale=>nil})
   -> 0.0016s
-- transaction_open?()
   -> 0.0000s
-- exec_query("SELECT COUNT(*) AS count FROM \"sprints\"")
   -> 0.0037s
-- exec_query("SELECT \"sprints\".\"id\" FROM \"sprints\" ORDER BY \"sprints\".\"id\" ASC LIMIT 1")
   -> 0.0007s
-- exec_query("SELECT \"sprints\".\"id\" FROM \"sprints\" WHERE \"sprints\".\"id\" >= 1 ORDER BY \"sprints\".\"id\" ASC LIMIT 1 OFFSET 1")
   -> 0.0003s
-- execute("UPDATE \"sprints\" SET \"state\" = \"sprints\".\"state_enum\" WHERE \"sprints\".\"id\" >= 1 AND \"sprints\".\"id\" < 2")
   -> 0.0005s
-- exec_query("SELECT \"sprints\".\"id\" FROM \"sprints\" WHERE \"sprints\".\"id\" >= 2 ORDER BY \"sprints\".\"id\" ASC LIMIT 1 OFFSET 1")
   -> 0.0003s
-- execute("UPDATE \"sprints\" SET \"state\" = \"sprints\".\"state_enum\" WHERE \"sprints\".\"id\" >= 2 AND \"sprints\".\"id\" < 3")
   -> 0.0004s
-- exec_query("SELECT \"sprints\".\"id\" FROM \"sprints\" WHERE \"sprints\".\"id\" >= 3 ORDER BY \"sprints\".\"id\" ASC LIMIT 1 OFFSET 1")
   -> 0.0003s
-- execute("UPDATE \"sprints\" SET \"state\" = \"sprints\".\"state_enum\" WHERE \"sprints\".\"id\" >= 3")
   -> 0.0004s
-- indexes(:sprints)
   -> 0.0035s
-- foreign_keys(:sprints)
   -> 0.0027s
-- quote_table_name(:sprints)
   -> 0.0000s
-- quote_column_name(:state)
   -> 0.0000s
-- quote_column_name(:state_enum)
   -> 0.0000s
-- execute("CREATE OR REPLACE FUNCTION trigger_f14363ffbcd3()\nRETURNS trigger AS\n$BODY$\nBEGIN\n  NEW.\"state_enum\" := NEW.\"state\";\n  RETURN NEW;\nEND;\n$BODY$\nLANGUAGE 'plpgsql'\nVOLATILE\n")
   -> 0.0089s
-- execute("DROP TRIGGER IF EXISTS trigger_f14363ffbcd3\nON \"sprints\"\n")
   -> 0.0002s
-- execute("CREATE TRIGGER trigger_f14363ffbcd3\nBEFORE INSERT OR UPDATE\nON \"sprints\"\nFOR EACH ROW\nEXECUTE PROCEDURE trigger_f14363ffbcd3()\n")
   -> 0.0012s
== 20200429002150 CleanupSprintsStateRename: reverted (0.0172s) ===============

== 20200429001827 SprintRenameStateToStateEnum: reverting =======================
-- execute("DROP TRIGGER IF EXISTS trigger_7873bd747066 ON sprints")
   -> 0.0011s
-- execute("DROP FUNCTION IF EXISTS trigger_7873bd747066()")
   -> 0.0004s
-- remove_column(:sprints, :state_enum)
   -> 0.0006s
== 20200429001827 SprintRenameStateToStateEnum: reverted (0.0034s) ==============

Refs #214713 (closed)

Edited May 12, 2020 by Mario de la Ossa

Add initial Iteration GraphQL endpoint