Skip to content

Dark theme for dropdowns in the Web IDE

Himanshu Kapoor requested to merge 213831-dark-theme-dropdowns into master

What does this MR do?

Issue #213831 (closed)

Adds dark theme support for the dropdowns (and tooltips) in the web IDE

  • Select branch/MR dropdown
  • File row dropdown
  • File/File template dropdown (for certain files like .gitignore)
  • Review dropdown (to compare changes with the MR or last changes)

Screenshots

Area Before After
Select branch Screenshot_2020-04-27_at_10.22.02_PM Screenshot_2020-04-27_at_10.16.31_PM
Select MR Screenshot_2020-04-27_at_10.22.14_PM Screenshot_2020-04-27_at_10.17.11_PM
File row Screenshot_2020-04-27_at_10.22.23_PM Screenshot_2020-04-27_at_10.17.26_PM
Review/Edit Screenshot_2020-04-27_at_10.22.49_PM Screenshot_2020-04-27_at_10.15.54_PM
File Template 1 Screenshot_2020-04-27_at_10.21.37_PM Screenshot_2020-04-27_at_10.17.59_PM
File Template 2 Screenshot_2020-04-27_at_10.21.50_PM Screenshot_2020-04-27_at_10.17.48_PM
Commit message tooltip Screenshot_2020-04-27_at_10.24.53_PM Screenshot_2020-04-27_at_10.37.14_PM
File search box (opened by Cmd+P) Screenshot_2020-05-01_at_7.11.36_PM Screenshot_2020-05-01_at_7.15.53_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Himanshu Kapoor

Merge request reports

Loading