Fix no-else-return eslint rule

What does this MR do?

Fix no-else-return eslint rule mostly using automatic fix, then going through each file to make sure styling is correct.

Screenshots

Before

✖ 347 problems (289 errors, 58 warnings)
  70 errors and 0 warnings potentially fixable with the `--fix` option.

After

✖ 317 problems (259 errors, 58 warnings)
  40 errors and 0 warnings potentially fixable with the `--fix` option.

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry
• Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers
• Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team