Skip to content

Hide broadcast messages till end of period

What does this MR do?

With the recent marketing message on gitlab.com it came apparent that we don't hide broadcast messages until the end of the broadcast message but just till the end of the browser session. We're using cookies to hide them but didn't set an expire date. This MR fixes this by adding an expire to the cookie to the ends_at date of the broadcast message (which must be set).

I'd say we could then close probably #208673 (closed) since the cookie is persistent till the end of the broadcast message.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Nicolas Dular

Merge request reports