Skip to content

Fix S/MIME signature for emails on push with multiple recipients

What does this MR do?

Sharing a single Mail instance and delivering multiple times caused the SMIME interceptor to be triggered multiple times for the same instance. This resulted in the email being signed multiple times.

This fixes the issue by cloning the Mail instance before changing the recipient and sending.

Related to #215152 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Heinrich Lee Yu

Merge request reports