Skip to content

Adjust rubocop rule for not valid FKs

Adam Hegyi requested to merge handle-not-valid-fk-addition-in-cop into master

What does this MR do?

This MR adjusts the rubocop rule for add_foreign_key. Normally we avoid using add_foreign_key since it validates the constraint within the same transaction. Instead of add_foreign_key we suggest to use add_concurrent_foreign_key. There is an exception where add_foreign_key is safe to use: adding a not valid FK.

If the FK definition contains validate: false the rubocop rule won't register an offense.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Adam Hegyi

Merge request reports