Fix CaptureDiffNotePositionService when position is nil (!30269) · Merge requests · GitLab.org / GitLab · GitLab

The 17.0 major release is coming on May 16, 2024! This version brings many exciting improvements to GitLab, but also removes some deprecated features. We are introducing three breaking change windows during which we expect breaking changes to be deployed to GitLab.com. You can read more about it on our blogpost . The first breaking change window begins 2024-04-22 09:00UTC and ends 2024-04-24 22:00UTC.

Igor Drozdov requested to merge id-fix-diff-note-position-service into master Apr 23, 2020

What does this MR do?

Fix CaptureDiffNotePositionService when position is nil

When a note is outdated, the position returned from PositionTracker is nil: https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/diff/position_tracer/line_strategy.rb#L173

We need to handle such a case: #215487 (closed)