Skip to content

Update Jira comment to include more information

What does this MR do?

Issue #195887 (closed)

In !29891 (merged), I added the comment_detail column.

I was considering splitting into separate backend and frontend MRs but putting them together makes testing easier. Keeping that in mind, this MR includes the following changes:

Backend

  • Add the branch name to Jira comments.
  • If comment_detail is set to all_details, include more information like commit SHA / MR number and full commit message as described in #195887 (closed).
  • Add some simple specs and update existing ones.

Frontend

  • Expand the Vue component to include the Jira trigger fields.
  • Add wrapping component IntegrationForm.
  • Add JiraTriggerFields which shows/hides sections based on user selection.
  • Use translations

Screenshots

GitLab

Screen_Shot_2020-04-28_at_10.49.04

Jira

Link to Jira issue used for testing (internal)

Entity Standard All details
Commit Screen_Shot_2020-04-27_at_10.39.40 Screen_Shot_2020-04-27_at_10.37.22
Merge request Screen_Shot_2020-04-27_at_10.40.27 Screen_Shot_2020-04-27_at_10.43.24

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports