Skip to content

Use stricter regex for broadcast target path

Nicolas Dular requested to merge nicolasdular/improve-target-path-regex into master

What does this MR do?

Issue: #215496 (closed) This changes our target path behaviour for broadcast messages. We're now stricter at matching the URL than before. Here is how it looks like:

Target path URL Before Now
/issues /gitlab-org/issues 🚫
/issues /gitlab-org/issues/123 🚫
*/issues /gitlab-org/issues
*/issues /gitlab-org/issues/123 🚫
/issues* /gitlab-org/issues/123 🚫
*/issues* /gitlab-org/issues/123

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Nicolas Dular

Merge request reports