Skip to content

Capture all errors when updating repository storage

James Fargher requested to merge shard_move_capture_all_errors into master

What does this MR do?

gitaly#2691 (closed)

There have been uncaptured exceptions leaving moved projects in a limbo state where their storage in the DB is updated, but the gitaly RPC actually failed. Here we are capturing all errors.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by James Fargher

Merge request reports