Skip to content

Add QA selector for "Close issue" button with "Report abuse" dropdown

Nailia Iskhakova requested to merge close-issue-button-spec into master

What does this MR do?

Closes #213750 (closed)

contribution_analytics_spec.rb intermittently fails with

Create Contribution Analytics tests contributions
      Failure/Error: Page::Project::Issue::Show.perform(&:click_close_issue_button)
      
      Capybara::ElementNotFound:
        Unable to find css "[data-qa-selector=\"close_issue_button\"],.qa-close-issue-button"
      # /usr/local/bundle/gems/capybara-3.29.0/lib/capybara/node/finders.rb:296:in `block in synced_resolve'

It appears that gitlab-qa-bot creates an issue in the project and gitlab-qa user sees "Close issue" button and "Report abuse" dropdown. For this case, we don't have a QA selector for "Close issue" button. This MR adds close_issue_button selector.

Screenshots

Screenshot from failed spec: link to artifacts

Comparison between "Close issue" with/without "Report abuse" dropdown:

Screenshot_2020-04-21_at_21.12.55

Does this MR meet the acceptance criteria?

Conformity

Edited by Nailia Iskhakova

Merge request reports