Skip to content

Modify existing out of runner minutes banner

Doug Stull requested to merge 212392-show-modify-existing-out-of-minutes into master

What does this MR do?

Updates the existing banner message according to how many minutes are left and thresholds for warning or error type messages.

Current

alert type(in UI terms) when to alert
danger below threshold percentage 30% or 5%
danger all minutes used

Change

alert type(in UI terms) when to alert
warning below threshold percentage of 30%
danger below threshold percentage of 5%
danger all minutes used

Screenshots

Before

Danger/Warning Level (30%-1%)

old_alert

Exceeded Level (<= 0%)

Screen_Shot_2020-04-21_at_2.11.30_PM

After

Warning Level (30%-6%)

Screen_Shot_2020-04-27_at_4.38.55_PM

Danger Level (5%-1%)

Screen_Shot_2020-04-27_at_4.37.55_PM

Exceeded Level (<= 0%)

Screen_Shot_2020-04-27_at_4.39.38_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #212392

Edited by Yorick Peterse

Merge request reports