Skip to content

Remove Spam flag when needing reCAPTCHA

charlie ablett requested to merge 214738-cablett-remove-spam-flag-recaptcha into master

What does this MR do?

Followon from !29748 (merged).

Once it's clear that there are no issues with !29748 (merged), we can remove the unneeded spam! declaration from the SpamActionService. That will complete the separation between something that is spammy looking (say, from Akismet) and something where we want to enforce a reCAPTCHA check for some other reason.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #214738 (closed)

Edited by charlie ablett

Merge request reports