Fix final_delay exception in MigrationHelpers
What does this MR do?
@krasio found a nasty bug in !25396 (comment 327730513) that causes CleanupOptimisticLockingNullsPt2 to crash under certain conditions.
If you have zero elegible records for one of the first tables to be migrated final_delay returns as nil. If you then have elegible records for the table that runs afterwards, you end up with initial_delay = nil which explodes once we try to sum it.
The fix is ridiculously simple, we just need to set final_delay = 0 instead of nil.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team