Skip to content

Remove deprecation_message from service

Justin Ho Tuan Duong requested to merge justin_ho-remove-unused-deprecated-message into master

What does this MR do?

  • deprecation_message is nil by default and no child classes are overwriting the value, thus it is always nil
  • Views are now redundant since they won't render

This MR cleans up the code used for the above.

Why is this change needed?

I am working towards using as much shared code as possible around integrations on the project / group / admin levels. This includes:

  • Using shared views like app/views/shared/integrations/edit.html.haml instead of app/views/projects/services/edit.html.haml.
  • Migrating towards a shared form written in Vue.

While reconciling the differences between the 2 views, I noticed the deprecated_message partial which is effectively not rendered at the moment. To make the migration easier, I have cleaned up the code as much as possible.

I am following the YAGNI principle here but in the unlikely case that similar functionality is needed, it should be trivial to add it back in. It will be DRY-er to do so once the views are consolidated and the need for copy-pasted code is reduced.

Screenshots

No changes to UI

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports