Apply fullscreen-layout to Design View
What does this MR do?
Adds a new class .layout-page.design-detail-layout, and applies it (in addition to some util classes) to the root .layout-page element when the user navigates to Design View. This fixes the bug outlined in #215229 (closed) (originally #14978 (closed)):
It's still possible to scroll the issue behind the modal. This can lead to a situation where there are multiple scrollbars.
Notes
Why not use .fullscreen-layout?
This existing class doesn't work out of the box for this usecase. We could add code to fix it, but this feels risky. Instead, a highly specific .layout-page.design-detail-layout is defined which does exactly and only what we want.
Is mobile/responsiveness affected?
Yes, in mostly a positive way. Because we are hiding the overlay, the issue raised in #210280 (closed) is "fixed". There are other mobile-related issues for design management/design view, but importantly, this change does not detract from the current experience.
Screenshots
| Before | After (notice most-outer-right scrollbar does not appear) |
|---|---|
 |
 |
Mobile
| Before (screen overflows horizontally (raised in #210280 (closed)) | After |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
- [-] Code review guidelines
- [-] Merge request performance guidelines
- [-] Style guides
- [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team