Enable uploadpack filters by default

What

This MR enables the 'gitaly_upload_pack_filter' feature flag by default to let people test partial clone out of the box. This feature flag already existed for some time.

People can still turn it off manually if they want to disable partial clone in case of abuse, performance issue or policy decision.

See related issues:

• gitaly#2553 (closed)
• git#56 (closed)

Owners

• Team: Gitaly
• Most appropriate slack channel to reach out to: #g_create_gitaly
• Best individual to reach out to: ZJ

Expectations

What are we expecting to happen?

This will make it easier for people to try and use partial clone.

What might happen if this goes wrong?

Too many resources could be used by partial clone for no good reason if people use it unappropriately. In this case the feature flag can be disabled manually, or people can be teached to use partial clone properly.

What can we monitor to detect problems with this?

Performance monitoring should be enough.

Beta groups/projects

If applicable, any groups/projects that are happy to have this feature turned on early. Some organizations may wish to test big changes they are interested in with a small subset of users ahead of time for example.

• gitlab-org/gitlab project
• gitlab-org/gitlab-com groups
• ...

Roll Out Steps

• Enable on staging
• Test on staging
• Ensure that documentation has been updated
• Enable on GitLab.com for individual groups/projects listed above and verify behaviour
• Coordinate a time to enable the flag with #production and #g_delivery on slack.
• Announce on the issue an estimated time this will be enabled on GitLab.com
• Enable on GitLab.com by running chatops command in #production
• Cross post chatops slack command to #support_gitlab-com (more guidance when this is necessary in the dev docs) and in your team channel
• Announce on the issue that the flag has been enabled
• Remove feature flag and add changelog entry
• After the flag removal is deployed, clean up the feature flag by running chatops command in #production channel

/label feature flag

Conformity

• Changelog entry
• Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers
• Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team

/cc @jramsay @zj-gitlab