Replace odd JSON usage with standard parser
What does this MR do?
Replaces the single instance of JSON[] in the codebase with a more standard JSON.parse. Related to #211671 (closed).
JSON[] is weird in that it either encodes or decodes JSON depending on whether you pass it a String, but in this instance it's only ever going to be parsing rather than dumping. And I don't like methods that return totally different things in a non-obvious way
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team