Skip to content

Fixes upload links not copying as GFM correctly

Phil Hughes requested to merge ph/214480/copyUploadLinks into master

What does this MR do?

Fixes upload links not copying as GFM correctly, this was caused by a missing data-link="true" attribute.

With just the gfm class the JS thinks its a reference (https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/assets/javascripts/behaviors/markdown/nodes/reference.js#L26) and tries to copy it as something a issue or merge request link like !1. If we add the data-link attribute we avoid this and just copy it as the link that it is 😄

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #214480 (closed)

Edited by Mayra Cabrera

Merge request reports