Skip to content

Resolve "Unify es_type as symbol or string"

Terri Chu requested to merge 197878-unify-es_type-as-symbol-or-string into master

What does this MR do?

Issue #197878 (closed)

Change usage of the es_type field in all method parameters, checks, and tests to use Strings instead of Strings or Symbols. Since es_type returns strings in all models, string was chosen as the standard. Removed any checks that converted to symbols (and back to string for pluralization). Changed all method param defaults and tests so that strings are used.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading