Ensure an annotation's position is of type Int
What does this MR do?
MouseEvent coordinates are specified as doubles (source: https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/offsetX). For the most part, they present themselves as integers (i.e. not decimals), but on the rare occasion they are decimals. UpdateDiffImagePositionInput and DiffImagePositionInput accepts Int for their coordinates, and in the case we do get a value with decimals, the mutation will fail and an exception is thrown.
This MR ensures all values we are attempting to mutation when either creating a new note or updating an existing one are rounded to Int. No user has reported this as a bug so I'm giving it ~backstage
Screenshots
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
- [-] Code review guidelines
- [-] Merge request performance guidelines
- [-] Style guides
- [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
- [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team