Geo - Set success to false in Geo::JobArtifactRegistry.insert_for_model_ids
What does this MR do?
The job_artifact_registry
table does not have a default value for the success
column. To avoid the madness of three-state booleans where it can be true
, false
, or NULL
we are setting it to false
when creating missing registries in the Geo::RegistryConsistencyWorker
.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related issues
Edited by Michael Kozono