Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 36,893
    • Issues 36,893
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 1,483
    • Merge requests 1,483
  • Requirements
    • Requirements
    • List
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Merge requests
  • !29528

Merged
Created Apr 14, 2020 by Paul Slaughter@pslaughter🔴Maintainer

Decouple presentation of note_awards_list

  • Overview 27
  • Commits 8
  • Pipelines 7
  • Changes 4

What does this MR do?

Refactors note_awards_list component by pulling out the presentational part into a vue_shared/components/awards_list.vue.

Why?

The Snippets Vue app needs a similar award component. By decoupling the presentation from the Vuex binding and note-specific behavior, we can now reuse awards_list.vue

Follow ups

We still need the ability to always show 👍 or 👎. For now, this MR focuses on just a pure refactor. We'll handle this enhancement in a follow up.

Screenshots

Still works 👍

20200416_emojis_still_work

Pinning test

To run the pinning tests locally, checkout this MR's branch and first revert the commit which removes the pinning test:

git revert --no-commit $(git log -1 --grep="Remove note_awards_list pinning test" --pretty=format:"%H")

Then run the test

yarn run jest spec/frontend/notes/components/note_awards_list_pin_spec.js

Ready to merge?

Feel free to remove the WIP label and git rebase -i origin/master --autosquash 😄

References

  • Related to #55650 (closed)
Edited Apr 16, 2020 by Denys Mishunov
Assignee
Assign to
Reviewer
Request review from
12.10
Milestone
12.10 (Past due)
Assign milestone
Time tracking
Source branch: 55650-refactor-notes-awards-components-for-reusability