Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 35,946
    • Issues 35,946
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1,279
    • Merge Requests 1,279
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Merge Requests
  • !29516

Merged
Opened Apr 14, 2020 by Justin Boyson@jboysonDeveloper0 of 3 tasks completed0/3 tasks

Multiline comments frontend MVC inline only

  • Overview 143
  • Commits 1
  • Pipelines 48
  • Changes 24

What does this MR do?

This is the proof of concept for the first iteration of multiline comments.

Related to #211255 (closed)

Related to #213010 (closed)

To test this feature you need to enable :multiline_comments

Feature.enable(:multiline_comments)

NOTE

This will save comments for both inline and side by side, but the line counts are off for side by side. In the spirit of iteration let's only review this from the inline perspective and submit a second MR for parallel.

Screenshots

Save comment form

image

Comment on only a single line

Notice there is no "X to X" verbiage

image

Multiline comment saved, showing which lines are commented on

image

Multiline comment in pending state

image

Pending comments list

image

Does this MR meet the acceptance criteria?

Conformity

  • [-] Changelog entry
  • [-] Documentation (if required)
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
Edited Jun 02, 2020 by Phil Hughes
Assignee
Assign to
Reviewer
Request review from
13.1
Milestone
13.1 (Past due)
Assign milestone
Time tracking
Reference: gitlab-org/gitlab!29516
Source branch: jdb/mutliline-comment-fe