Skip to content

Refactor ProjectMembers and GroupMembers controllers

Dmytro Zaporozhets (DZ) requested to merge dz-refactor-member-controllers into master

What does this MR do?

  1. Refactor ProjectMembers and GroupMembers controllers. Make them look alike.
    • Consistent finder execution
    • Move unrelated logic outside of present_ methods
    • Remove find_members method and move the logic to the index method
    • For consistency with GroupMembers, use params.slice for ProjectMembers too. Extract into filter_params method for both controllers.
  2. Move params for MembersFinder under initialize to be consistent with GroupMembersFinder and most of other finders.

Closes #118630 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Edited by Dmytro Zaporozhets (DZ)

Merge request reports