Skip to content

Replace deprecated GlLoadingIcon sizes

What does this MR do?

Replaces deprecated GlLoadingIcon sizes with actual.

This is required for continuing the Jestodus project for moving our tests to Jest. Some components throw an error about deprecated size and tests fail because of that. And it removes the deprecation warning from the browser.

Size mappings:

const sizeToStringMap = {
  1: sizes.sm,
  2: sizes.lg,
  3: sizes.lg,
  4: sizes.xl,
  5: sizes.xl,
};

Screenshots

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports