Skip to content

Do not ignore database connection errors

Dmitry Gruzd requested to merge 205640-dont-ignore-database-errors into master

What does this MR do?

Whenever sidekiq loses a database connection the jobs will just immediately return success without doing anything because we return fake settings.

This MR changes the way database connection errors are handled for ApplicationSetting. Now instead of returning Gitlab::FakeApplicationSettings whenever we lost the database connection we limit that behaviour to rake tasks. Otherwise we just raise an exception and sidekiq jobs will be rescheduled instead of silently dropping.

#205640 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports