Skip to content

Use of dashboard fixtures to remove mock data

Miguel Rincon requested to merge cleanup-dashboard-data into master

What does this MR do?

Since the introduction of fixtures its possible to remove some mock data from the specs. This refactoring MR removes some mock data that has moved to the json fixture.

Specifically:

  • Removes mocks from mock_data.js that is redundant with data in the fixture.
  • Creates a new file called fixture_data.js to keep data loaded from the fixture in different formats (mutated by the store vs. as the original JSON).
  • Rewrite of (store_utils.js) to hold store manipulation functions (such as adding a metric result).
  • Removes some unused localVue instances.

Screenshots

N/A

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports