Set Gold plan on sandbox group in live environments
What does this MR do?
Sets gold plan on top level group as plans cannot be selected on sub-level groups. This only effects live environments such as staging. Also the test is still in quarantine.
Also ensures that the test signs out in after
block.
Related to #212544 (closed)
Conformity
Merge request reports
Activity
changed milestone to %12.10
marked the checklist item Code review guidelines as completed
marked the checklist item Merge request performance guidelines as completed
marked the checklist item Style guides as completed
1 Warning The merge request title length is acceptable, but please try to reduce it to 50 characters.. For more information, take a look at our Commit message guidelines. 1 Message CHANGELOG missing: If this merge request doesn’t need a CHANGELOG entry, feel free to ignore this message. If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 29317 "Set Gold plan on sandbox group in live environments"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 29317 "Set Gold plan on sandbox group in live environments"
Note: Merge requests with ~backstage, ci-build, meta do not trigger this check.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer QA Tomislav Nikić ( @tmslvnkc
)Ramya Authappan ( @at.ramya
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/pipelines/134689603 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/pipelines/134692847 downstream.The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/pipelines/134692847 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/pipelines/134716739 downstream.The
gitlab-qa
downstream pipeline failed! .The failure is unrelated and was fixed in !29247 (merged). (Rebase should pass)
@tmslvnkc Could you review please? (I'm assigning it to you without waiting for the
package-and-qa
job because the test is still in quarantine and the change only affects the run against a live environment sopackage-and-qa
is irrelevant).Edited by Sanad Liaquatadded Pick into auto-deploy label
@at.ramya Since Tomi is out today, Could you review and merge this minor change please?
assigned to @at.ramya and unassigned @tmslvnkc
mentioned in commit 20aabab6
picked the changes into the branch
12-10-auto-deploy-20200412
with commit dbd7bacdmentioned in commit dbd7bacd
removed Pick into auto-deploy label