Skip to content

Expose work information on User

Magdalena Frankiewicz requested to merge add-work-information-to-user-api into master

What does this MR do?

Solves #210586 (closed)

Screenshots

Page Before After
User Popover Screen_Shot_2020-04-09_at_11.17.41_AM Screen_Shot_2020-04-09_at_11.16.00_AM

The frontend case for removing job_title and organization from the /api/:version/users/:id endpoint

This is where the frontend API call is made from: app/assets/javascripts/api.js

The only place this call is being made is in app/assets/javascripts/lib/utils/users_cache.js

The only three components that use app/assets/javascripts/lib/utils/users_cache.js are:

Of those the only file that references organization or job_title is app/assets/javascripts/user_popovers.js

Update: job_title and organization can't be removed because this a public facing API

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Magdalena Frankiewicz

Merge request reports