Skip to content

Async delete in the container repository list

Nicolò Maria Mezzopera requested to merge 208429-implement-async-delete into master

What does this MR do?

This MR:

  • Moves all the translations strings to the constant file
  • Replace the delete toast messages with an alert
  • Enable async delete for Image Repositories in this way:
    • User click delete button
    • Delete call is sent to the BE
    • Row element is marked as deleted and fades
  • If the async delete errored we now display a warning icon with a tooltip
  • Removes the admin warning about running the garbage collection on the list page since it could be a wrong tip
  • Fixes a piece of wrong copy

Notes

Why has the admin tip about running garbage collection been removed from this page? This is because we are 'scheduling' a deletion here, and this can be potentially a long-running task, so there may be no garbage collection to run here at all. The tip has been preserved in the tag deletion which instead is synchronous

Screenshots

Async delete error on the first row

Updated with icon on the right

Screenshot_2020-04-09_at_14.38.40

Succesful delete

Screenshot_2020-04-09_at_10.31.10

Successful delete with faded row

Desktop

Screenshot_2020-04-09_at_15.07.08

Small screen

Screenshot_2020-04-09_at_15.05.30

Unsucessful delete

Not updated with icon on the right and new tooltip position

Screenshot_2020-04-09_at_10.32.15

Screencast of the happy path

Not updated with icon on the right and new tooltip position

screen-capture__42_

Does this MR meet the acceptance criteria?

Screencast when there is an error in the delete request

Not updated with icon on the right and new tooltip position

screen-capture__43_

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Part of #208429 (closed)

Edited by Nicolò Maria Mezzopera

Merge request reports