Fix Slack notifications when upgrading from old GitLab versions
What does this MR do?
Issue #212073 (closed)
There is a bug that when setting up a SlackService without specifying any channels, the integration will not work. This only happens in the particular instance when you have upgraded from an old GitLab version (haven't been able to pinpoint which version). For those users, there is an extra "channel"=>"" property, likely from a previous UI which did not allow multiple event_types.
This MR checks for .presence of channel so it can be removed if it's only set to an empty string.
Root cause: We should have sanitized the backend data when introducing new features (like event_types) and removed the unused columns, so it didn't come back and bite us later on.
Full credit to @stanhu for identifying the issue.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team