Skip to content

Update query labels dynamically for embedded charts

David O'Regan requested to merge 195739 into master

What does this MR do?

A tiny MR to help address: #195739 (closed)

Here we're attempting to apply substitution-based labels, then fallback to data from the prometheus response to build the labels, then finally fallback to the user-defined label only if the first 3 approaches didn't give us a valid label for the charts.

Further Work Needed

A MR inside the @gitlab/ui legend.vue && tooltip_default_format.vue to truncate long series labels.

Supporting MR here: gitlab-ui!1274 (merged)

Screenshots

Screenshot_2020-04-07_at_12.02.45 Screenshot_2020-04-07_at_12.58.18 Screenshot_2020-04-07_at_12.58.22 Screenshot_2020-04-07_at_13.19.28 Screenshot_2020-04-07_at_13.19.37

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports