Skip to content

Move Clusters::Applications::Runner to batch counting

What does this MR do?

Move ::Clusters::Applications::Runner.where(time_period).distinct_by_user, to batch distinct count

The purpose of the change

This changes are a performance improvement of count queries and a refactoring. We prefer to use batch counting and optimize indexes if is the case in order to have the queries under 1 sec and avoid the timeouts.

Proposed solution

  • Refactor the counter to use batch counting
  • Ensure that the resulted queries are < 1 sec in database-lab
  • No need for optimization
time_period = {}
clusters_applications_cert_managers: distinct_count(::Clusters::Applications::Runner.where(time_period).available.joins(:cluster), 'clusters.user_id'),
time_period = { created_at: 28.days.ago..Time.current }
clusters_applications_cert_managers: distinct_count(::Clusters::Applications::Runner.where(time_period).available.joins(:cluster), 'clusters.user_id'),

Queries

MIN with no period

SELECT MIN(clusters.user_id)
FROM "clusters_applications_runners"
INNER JOIN "clusters" ON "clusters"."id" = "clusters_applications_runners"."cluster_id"
WHERE "clusters_applications_runners"."status" IN (3, 5)

Time: 764.056 ms https://explain.depesz.com/s/OkSu

Filter: (clusters_applications_runners.status = ANY ('{3,5}'::integer[]))

MAX with no period

SELECT MAX(clusters.user_id)
FROM "clusters_applications_runners"
INNER JOIN "clusters" ON "clusters"."id" = "clusters_applications_runners"."cluster_id"
WHERE "clusters_applications_runners"."status" IN (3, 5)

Time: 33.877 ms https://explain.depesz.com/s/WHy3

Filter: (clusters_applications_runners.status = ANY ('{3,5}'::integer[]))

COUNT with no period

SELECT COUNT(DISTINCT clusters.user_id)
FROM "clusters_applications_runners"
INNER JOIN "clusters" ON "clusters"."id" = "clusters_applications_runners"."cluster_id"
WHERE "clusters_applications_runners"."status" IN (3, 5)
  AND "clusters"."user_id" BETWEEN 0 AND 9999

Time: 2.246 ms https://explain.depesz.com/s/SqG7

Filter: (clusters_applications_runners.status = ANY ('{3,5}'::integer[]))

MIN with period

SELECT MIN(clusters.user_id)
FROM "clusters_applications_runners"
INNER JOIN "clusters" ON "clusters"."id" = "clusters_applications_runners"."cluster_id"
WHERE "clusters_applications_runners"."created_at" BETWEEN '2020-03-10 08:31:44.043840' AND '2020-04-07 08:31:44.043994'
  AND "clusters_applications_runners"."status" IN (3, 5)

Time: 5.075 ms https://explain.depesz.com/s/70tP

Filter: ((clusters_applications_runners.created_at >= '2020-03-10 08:31:44.04384+00'::timestamp with time zone) AND (clusters_applications_runners.created_at <= '2020-04-07 08:31:44.043994+00'::timestamp with time zone) AND (clusters_applications_runners.status = ANY ('{3,5}'::integer[])))

MAX with period

SELECT MAX(clusters.user_id)
FROM "clusters_applications_runners"
INNER JOIN "clusters" ON "clusters"."id" = "clusters_applications_runners"."cluster_id"
WHERE "clusters_applications_runners"."created_at" BETWEEN '2020-03-10 08:31:44.043840' AND '2020-04-07 08:31:44.043994'
  AND "clusters_applications_runners"."status" IN (3, 5)

Time: 5.524 ms https://explain.depesz.com/s/2mhD

Filter: Filter: ((clusters_applications_runners.created_at >= '2020-03-10 08:31:44.04384+00'::timestamp with time zone) AND (clusters_applications_runners.created_at <= '2020-04-07 08:31:44.043994+00'::timestamp with time zone) AND (clusters_applications_runners.status = ANY ('{3,5}'::integer[])))

COUNT with period

SELECT COUNT(DISTINCT clusters.user_id)
FROM "clusters_applications_runners"
INNER JOIN "clusters" ON "clusters"."id" = "clusters_applications_runners"."cluster_id"
WHERE "clusters_applications_runners"."created_at" BETWEEN '2020-03-10 08:31:44.043840' AND '2020-04-07 08:31:44.043994'
  AND "clusters_applications_runners"."status" IN (3, 5)
  AND "clusters"."user_id" BETWEEN 0 AND 9999

Time: 1.353 ms https://explain.depesz.com/s/kmKu

Filter: ((clusters_applications_runners.created_at >= '2020-03-10 08:31:44.04384+00'::timestamp with time zone) AND (clusters_applications_runners.created_at <= '2020-04-07 08:31:44.043994+00'::timestamp with time zone) AND (clusters_applications_runners.status = ANY ('{3,5}'::integer[])))

Part of #212962 (closed)

Edited by Alina Mihaila

Merge request reports