Update several MergeRequest and Pipeline specs
What does this MR do?
Refactors a few specs to use updated factories and be compatible with a change being made to Ci::Pipeline#all_merge_requests
. The specs didn't always completely reflect the current setup of merge request pipelines, and changing the specs in a separate MR and then sending the refactor after seems safer than refactoring code and the relevant specs at the same time.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
Changelog entryDocumentation (if required)-
Code review guidelines Merge request performance guidelines-
Style guides Database guides-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by drew stachon