Add instance setting to manage default branch protection in groups
requested to merge 211944-provide-instance-level-setting-to-enable-or-disable-the-updation-of-default-branch into master
What does this MR do?
For #211944 (closed), part 2.
A detailed note on how the proposed feature should function is noted here
Part 1: !29879 (merged).
The required database column for this change was already added in !29397 (merged)
Changes made
In Part 1, we made all the requires changes and introduced new policies in CE.
This MR contains only EE specific changes, and prevent
s the policies introduced in CE, based on the requirement of the feature, as mentioned in #211944 (closed).
-
Allow to change the setting from group_owners_can_manage_default_branch_protection
fromadmin/application_settings/general
-
Expose the setting via Application Settings API (GET/PUT) -
Based on the value of the group_owners_can_manage_default_branch_protection
setting and the availability of the Licensed feature, allow or prevent owners changing thedefault branch protection
of the group. (Instance admins will always be allowed to change default branch protection of groups)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Manoj M J